Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checks on the "self" parameter when a Lua command executes a virtual function on vessel objects.
Prior to this, there were opportunities for CTD when the user forgot to use the ":" notation when calling a vessel method.
A proper Lua error is now propagated when we try to convert a non vessel object to a VESSEL *.
Orbiter vessels providing Lua bindings have also been updated to check for proper type before casting userdata to VESSEL objects.
Note : luaL_checkudata is not used in the interpreter because we cannot know what type of vessel is to be expected. Instead a set of VESSEL objects is maintained and checked against to test if a userdata is associated with a known vessel.
This method is robust to vessel deletion. If for example you do
v=vessel.get_interface("ISS")
then delete the ISS from the scenario editor
then
print(v:get_name())
it generates an error instead of a crash.