Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua]Add support for oapiOpenInputBoxEx #456

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

TheGondos
Copy link
Contributor

This PR adds support for the oapiOpenInputBoxEx function in ScriptVessels/ScriptMFDs
Differences with the C++ version :
-callbacks only take 2 arguments (str and usrdata) since the first "void *id" is useless
-cancel callback does not need to return a bool since it's ignored by the core anyway

@TheGondos TheGondos marked this pull request as draft April 7, 2024 16:53
@TheGondos
Copy link
Contributor Author

What's the strategy for the Lua documentation? I don't like adding new APIs without at least minimal documentation...

@jarmonik
Copy link
Contributor

jarmonik commented Apr 7, 2024

There is no strategy for LUA documentation as far as I can tell. So, would you have some recommendations ?
Would it be possible to exploit doxygen and modified versions of OrbiterAPI.h and VesselAPI.h for documentation ?

@TheGondos
Copy link
Contributor Author

OK, I was not sure if the API doc was handled in the LaTeX work or not. I'll try to see what I can do with the ldoc stuff lying around then.
I won't do this in this PR so it's ready to merge

@TheGondos TheGondos marked this pull request as ready for review April 8, 2024 22:33
@jarmonik jarmonik merged commit 3c336b1 into orbitersim:main Apr 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants