Add support for VS2022

[TheGondos]

This PR fixes the build issues when compiling with VS2022, it also adds CI jobs to detect potential future failures.
The artifacts for the VS2022 builds are not saved for now.

[spacex15]

there is a similar problem in planet.cpp

[TheGondos]

there is a similar problem in planet.cpp

Sweet lord, is it the last of the VS2022 issues?

[TheGondos]

Changing to draft until everything is sorted out, maybe we should add a VS2022 CI build to prevent future issues

[jarmonik]

The latest step might have caused Git CI to crash. Cancelled job after several hours of inactivity.
Status was "Waiting xxx to pickup the job"

[TheGondos]

The latest step might have caused Git CI to crash. Cancelled job after several hours of inactivity. Status was "Waiting xxx to pickup the job"

Thanks, I saw it was stuck but didn't know how to kill it.
I tried to follow the documentation, but I now realize that specifying a list limits the matching for a runner instead of making several runs...

[TheGondos]

It now builds OK but there is a conflict when exporting the artifacts because (I guess) they are named "Orbiter-${{ matrix.architecture }}" and it resolves the same for the windows-2019 and windows-2022 runners.
I don't know if modifying the "if:" like this will solve the issue (by only exporting the windows-2019 artifacts) :
if: ${{ github.ref == 'refs/heads/main' and matrix.os == 'windows-2019' }}
Let me know if you know, I'll try to play with this tomorrow

[dimitry-ishenko]

Maybe drop windows-2019 altogether, and just leave windows-2022? It's only 2024 outside... 😉

[jarmonik]

I have very little experience with building the artifacts so can't really advice there. If you think you can direct it to build only 2019 artifact then it's worth trying. Removing the 2019 artifact would reverse the problem, code compiled on 2022 might not run on 2019 but the probability is likely lower. If the first option is giving too much trouble then lets disable VS2019 build, we can restore it if a problem arise.

[TheGondos]

Not a fan of switching artifacts to vs2022 right now for the 32bit version, who knows what kind of hidden surprises it involves compatibility-wise.

[TheGondos]

Looks like we got a winner, I'll squash everything if you're OK to include this.

[jarmonik]

It look good as far as I can tell. 👍