Clean-up patches #341
Clean-up patches #341
Conversation
Mark string literals and functions using them as const. Remove useless char* pointers pointing to global char[N] arrays, since std::cin can't operate on char*.
|
The change to the Date2Int() function parameters seems to have caused certain celestial bodies to throw errors while loading into a simulation. In no particular order, the offenders are Phobos, Deimos, Miranda, Ariel, Umbriel, Titania, and Oberon. They complain about a "procedure entry point not found" for the function Date2Int, which did not happen prior to this PR. |
|
This bug would've been discovered by opening the simulation once. Please make sure that we aren't introducing bugs. The issue here is that those moon modules can't be rebuilt (because we don't have the source). They will need to be replaced. The change is good, but we can't be breaking the Orbiter in the process. I am very happy to be a reviewer on these if you want. |
|
Sorry guys, that's my bad. I've reverted it on my end but forgot to push before submitting the PR. Will fix shortly. |
|
I've submitted PR #345 with the fix. |
This is a first batch of clean-up patches discussed in #338 to enable C++20 standard conformance.
The purpose of these patches is to enable C++20 conformance of the existing code with minimal changes, so that further clean-up can be done as the next step.
The patches were purposely made very small and easy to review/accept, and will also aid any further bisects if necessary to find bugs.