Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

211 module deletion #212

Merged
merged 5 commits into from
Aug 20, 2022
Merged

211 module deletion #212

merged 5 commits into from
Aug 20, 2022

Conversation

mschweiger
Copy link
Collaborator

@mschweiger mschweiger commented Aug 20, 2022 •
edited
Loading

  • Cleaned up module registration and un-registration in Orbiter core.
  • Plugin DLLs are responsible for deleting the their module instances after unregistering them with Orbiter.
  • Additional log output to diagnose problems with module registration/unregistration.
  • Clearer way for plugins to register an unregister items in the Launchpad Extra tab.
  • Inline and D3D7 clients now properly unregister and deallocate their resources.

Closes #211

@mschweiger
#211: Orbiter core no longer deletes module instances registered from…
71f2323 
… loaded DLL plugins. D3D7Client now unregisters and deletes its own instance.
@mschweiger
#211: cleaned up module-related code in Orbiter core. Plugin referenc…
639dfa5 
…es are now kept in a std::list.
@mschweiger
#211: module loading and unloading events now registered in log file.…
eec0532 
… Log timestamps: now measured from app start, so they give useful values outside simulation sessions.
@mschweiger
#211: fixed bug in logging module unregistering. Added check for orph…
246bb52 
…aned launchpad items. Inline graphics clients now cleans up its launchpad items.
@mschweiger
#211: Module LuaInline now deletes its instance on exit.
79f59bc
@mschweiger mschweiger merged commit 85e9a3c into main Aug 20, 2022
@mschweiger mschweiger deleted the 211-module_deletion branch August 20, 2022 22:26
@mschweiger mschweiger mentioned this pull request Aug 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module instances from DLLs should not be deleted by Orbiter
1 participant
@mschweiger