Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Fix 64bit compiler warnings #162

Merged
merged 1 commit into from
Jan 16, 2022
Merged

- Fix 64bit compiler warnings #162

merged 1 commit into from
Jan 16, 2022

Conversation

riojax
Copy link
Contributor

@riojax riojax commented Jan 16, 2022

  • Fix 64bit compiler warnings
  • DrawAPI.h Add FMATRIX4 initialization
  • Use proper encoding
  • Click area only on focused vessels

- DrawAPI.h Add FMATRIX4 initialization
- Use proper encoding
- Click area only on focused vessels
@jarmonik jarmonik merged commit 6d09f3a into orbitersim:d3d9client Jan 16, 2022
@jarmonik
Copy link
Contributor

Is there a reason why some special charters are replaced with their ASCII code ?

@riojax
Copy link
Contributor Author

riojax commented Jan 16, 2022

That's because modern MSVC compilers don't use Windows-1252 encoding by default, but this is the encoding that we need to render it properly, by that I hardcoded some characters on Windows-1252.
Other option is use the /source-charset and /execution-charset switches on CL.EXE, but this is unreliable and is prefered to hardcode it.

@jarmonik
Copy link
Contributor

Ok thanks. I wasn't aware that this kind of problem has emerged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants