Deleting vessel cause crash when running with external graphic client

[spacex15]

Testing on the d3d9client branch

The external graphic client clbkDeleteVessel is never called by orbiter core

I got a crash running in debug mode because of this

I suggest to change the following code in orbiter.cpp

#ifdef INLINEGRAPHICS
oclient->clbkDeleteVessel ((OBJHANDLE)vessel);
#endif

to

#ifdef INLINEGRAPHICS
oclient->clbkDeleteVessel ((OBJHANDLE)vessel);
#else
if(gclient)
gclient->clbkDeleteVessel((OBJHANDLE)vessel);
#endif

same problem exists with other virtual module functions

Or maybe the d3d9client should register these functions ?

[riojax]

Please, can you retest it?

[spacex15]

Thanks for implementing this

Yes it will work (although I must admit I tested on jarmonik/d3d9client repo branch,
I wonder why this new d3d9client version is still to be merged into main repo )

Please note that the same issue occurs in 3 other locations in orbiter.cpp
for the newvessel ,vesseljump and timejump events

see below the suggested fixes

#ifdef INLINEGRAPHICS
oclient->clbkNewVessel ((OBJHANDLE)vessel);
#else
if (gclient)
gclient->clbkNewVessel((OBJHANDLE)vessel);
#endif // INLINEGRAPHICS

#ifdef INLINEGRAPHICS
oclient->GetScene()->Update (g_psys, &g_camera[0], 1, false/m_bRunning/, false);
#else
if (gclient)
gclient->clbkVesselJump((OBJHANDLE)obj);
#endif // INLINEGRAPHICS

#ifdef INLINEGRAPHICS
if (oclient) oclient->clbkTimeJump (td.SimT0, tjump.dt, _mjd);
#else
if (gclient)
gclient->clbkTimeJump(td.SimT0, tjump.dt, _mjd);
#endif

[riojax]

Thank you a lot, this is a huge PR with all your suggested fixes.