Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orb-ui): #199 remove asterisk policy view #2298

Merged
merged 4 commits into from
Apr 14, 2023
Merged

fix(orb-ui): #199 remove asterisk policy view #2298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a5c978
fix(orb-ui): #151 - fix name labels for sink and policy
joaoguilherme2003 Mar 23, 2023
0f163e4
fix(orb-ui): tooltip correction on policy view page
joaoguilherme2003 Mar 27, 2023
cb2a483
fix(orb-ui): URL on See Here button on agent credentials
joaoguilherme2003 Apr 3, 2023
1f88644
fix(orb-ui): #199 remove asterisk policy view
joaoguilherme2003 Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/app/pages/datasets/policies.agent/add/agent.policy.add.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ <h4>{{ isEdit ? 'Edit Agent Policy' : 'Create Agent Policy'}}</h4>
<div>
<label
class="font-weight-bold"
for="name">Name Label</label>
for="name">Sink Name</label>
<span class="required">*</span>
</div>
<input
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/pages/fleet/agents/key/agent.key.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

<label>Provisioning Command</label>
<p>
<a href="https://getorb.io/docs/#running-orb-agent"
<a href="https://orb.community/documentation/running_orb_agent/"
target="_blank">See here
</a>
for more advanced options.
Expand Down
4 changes: 2 additions & 2 deletions ui/src/app/pages/sinks/add/sink.add.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ <h4>{{strings.sink[isEdit ? 'edit' : 'add']['header']}}</h4>
<nb-form-field>
<div class="d-flex flex-column">
<div>
<label class="font-weight-bold">Name Label</label>
<label class="font-weight-bold">Sink Name</label>
<span class="required">*</span>
</div>
<input autofocus
Expand Down Expand Up @@ -247,7 +247,7 @@ <h4>{{strings.sink[isEdit ? 'edit' : 'add']['header']}}</h4>
<div class="d-flex row">
<div class="col-md-12 col-xl-6">
<div>
<label class="font-weight-bold">Name Label</label>
<label class="font-weight-bold">Sink Name</label>
<p data-orb-qa-id="review-name">{{firstFormGroup?.controls.name.value}}</p>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/shared/components/orb/policy/policy-datasets/policy-datasets.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@

<ng-template #groupTemplateCell let-i="index" let-row="row" let-value="value">
<button (click)="onOpenGroupDetails(row?.agent_group)"
class="edit-dataset-button" nbTooltip="{{ row?.agent_group?.id }}">
class="edit-dataset-button" matTooltip="{{ row?.agent_group?.name }}">
{{ row?.agent_group?.name }}
</button>
</ng-template>
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/shared/components/orb/policy/policy-details/policy-details.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<ng-template #readView>
<div class="d-flex flex-column">
<div class="flex-row">
<label class="summary-accent">Name<span class="required">*</span></label>
<label class="summary-accent">Name</label>
<p>{{ policy?.name }}</p>
</div>
<div class="flex-row">
Expand Down