Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add MaxLen to avoid redis be filled #2279

Merged
merged 3 commits into from
Mar 22, 2023
Merged

[FIX] Add MaxLen to avoid redis be filled #2279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f04d933
Update sinker.go
etaques Mar 22, 2023
1659cd4
adding MaxLen for capped stream args
etaques Mar 22, 2023
9f9998f
add MaxLan on streams
etaques Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions maestro/redis/consumer/hashset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ func (es eventStore) PublishSinkStateChange(sink *sinkspb.SinkRes, status string

record := &redis2.XAddArgs{
Stream: streamID,
MaxLen: 1000,
Values: event.Encode(),
}
err = es.streamRedisClient.XAdd(context.Background(), record).Err()
Expand Down
4 changes: 4 additions & 0 deletions sinker/redis/producer/streams.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ func (e eventStore) DeployCollector(ctx context.Context, config config.SinkConfi
}
recordToSink := &redis.XAddArgs{
Stream: streamID,
MaxLen: 1000,
Values: eventToSink.Encode(),
}
err = e.client.XAdd(ctx, recordToSink).Err()
Expand Down Expand Up @@ -66,6 +67,7 @@ func (e eventStore) Add(config config.SinkConfig) error {
}
record := &redis.XAddArgs{
Stream: streamID,
MaxLen: 1000,
Values: event.Encode(),
}
err = e.client.XAdd(context.Background(), record).Err()
Expand All @@ -89,6 +91,7 @@ func (e eventStore) Remove(ownerID string, sinkID string) error {
}
record := &redis.XAddArgs{
Stream: streamID,
MaxLen: 1000,
Values: event.Encode(),
}
err = e.client.XAdd(context.Background(), record).Err()
Expand Down Expand Up @@ -117,6 +120,7 @@ func (e eventStore) Edit(config config.SinkConfig) error {
}
record := &redis.XAddArgs{
Stream: streamID,
MaxLen: 1000,
Values: event.Encode(),
}
err = e.client.XAdd(context.Background(), record).Err()
Expand Down
1 change: 1 addition & 0 deletions sinker/redis/sinker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ func (s *sinkerCache) DeployCollector(ctx context.Context, config sinkerconfig.S
encodeEvent := redis.XAddArgs{
ID: config.SinkID,
Stream: idPrefix,
MaxLen: 1000,
Values: event,
}
if cmd := s.client.XAdd(ctx, &encodeEvent); cmd.Err() != nil {
Expand Down