feat(agent): fix context propagation for failure in otel #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com>
Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com>
etaques
added a commit
that referenced
this pull request
Feb 20, 2023
* [FIX] orb helm url (#2154) [FIX] orb helm url (#2154) * [FIX] chart lock url on kind environment (#2156) [FIX] chart lock url on kind environment (#2156) * new status for policy with no tap match (#2155) * [ORB-203] Enable sink status update by listening to otel-collector logs. (#2135) [ORB-203] Enable sink status update by listening to otel-collector logs. (#2135) * [FIX] change organization to orb-community (#2157) [FIX] change organization to orb-community (#2157) * feat(maestro): fix message with error in mid-sentence. (#2158) feat(maestro): fix message with error in mid-sentence. (#2158) * fix(fleet): fix group tags editing - make it unable to delete tags (#2152) * fix group tags editing - make it unable to delete tags * typo(agent): fix no_tap_match status typo * fix(fleet): partial updates for agent and endpoint unit tests * fix(fleet): partial updates for agent and service unit tests * Remove otel collector health_check extension unused (#2159) Remove otel collector health_check extension unused (#2159) * Removing logging extension on otel collector (#2160) Removing logging extension on otel collector (#2160) * [FIX] DeployCollector function (#2162) [FIX] DeployCollector function (#2162) * Update README.md (#2161) * Update README.md * [FIX] adding ownerid on decode GRPC sinks response (#2163) * fix(maestro): sinks status fix on active and errored sinks * [FIX] on logic for active and error sinks status * symplify analyzeLogs function * lastRemoteWrite is actually controlled by sinker * fix message * remove comments * remove unnecessary * deployment status should be internally controlled * fix err variable * add comments * fix comment * fix comments * add error if collector was not found * fix error * add changes * add changes * fix maestro lastactivity * fix maestro lastactivity * fix condition for idle * remove idle control on sinker * deployment check * feat(migrate): add migrate service to default and support openTelemetry in all sinks (#2150) * feat(migrate): add migrate service, to add/remove openTelemetry, add control flag there to be able to rollback if necessary. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(sinker): remove skip, and add deprecation message. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(sinker): fix deprecation message. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(sinks): add default values for OpenTelemetry sink. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(ui): remove sinks OpenTelemetry flag. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(sinks): fix opentelemetry tag case Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(UI): remove OpenTelemetry flag. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(makefile): add kubectl rollout in makefile. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(migrate): fix identation. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(charts): testing chart migrate true. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(maestro): add otel flag enabled as true. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(maestro): re-add after testing. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * [FIX] refactoring maestro event sourcing for sink status (#2165) [FIX] refactoring maestro event sourcing for sink status (#2165) * Fix delete sinks on maestro (#2167) Fix delete sinks on maestro (#2167) * [Feat] Remove otel collector when it is idle (#2168) * feat(maestro): update cache with creation of yaml. (#2169) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix failed to parse json (#2170) * feat(maestro): update cache with creation of yaml. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(maestro): fix parse of json. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(maestro): add debug log. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * [FIX] maestro event sourcing to update otel collector (#2171) [FIX] maestro event sourcing to update otel collector (#2171) * increasing timeout for sink status because of otel (#2172) * feat(migrate): prevent previous migration from executing in migrate up/down. (#2174) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(agent): fix context propagation for failure in otel (#2166) * feat(agent): fix context propagation for failure in otel Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(agent): add context propagation. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinks): fix merging of the sinks tags and config. (#2176) * fix(sinks): fix merging of the sinks tags and config. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinks): fix tests Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinker): fix not removing sinker cache when removing sink. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * [FIX] do not skip when lastActivity not found on redis (#2175) * do not skip when lastactivity not found * [FIX] only check last activity after error * fix variables * fix variables --------- Co-authored-by: Luiz Henrique Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix state change to remove the local cache, refactored code, to only redis package have redisClient (#2177) * fix(maestro): replace local cache for wait mechanism in getting the deployment state Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): add secondary step validation Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): focused every redis integration into redis eventStream service. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix maestro redis proper client. (#2178) * fix(maestro): fix maestro redis proper client. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): reduce time to check for pod creation Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): added fine tuning to maestro. (#2179) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * Fine tuning maestro (#2180) * fix(maestro): added fine tuning to maestro. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): added fine tuning to maestro. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): more fine tuning in wait periods for k8s Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): more fine-tuning in wait periods for k8s. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinks): add remote_host validation to prevent users to create sinks with invalid url Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinks): fix tests to adapt to new error Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * Sink error message (#2182) * fix(maestro): added fine tuning to maestro. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): added fine tuning to maestro. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): more fine tuning in wait periods for k8s Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): more fine-tuning in wait periods for k8s. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinks): add remote_host validation to prevent users to create sinks with invalid url Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinks): fix tests to adapt to new error Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinks): fix error message. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro-): extracted change of status. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * Sinker ifs state (#2183) * fix(sinker): fix if nesting Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinker): fix if nesting Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(maestro): fix error messages (#2184) * fix(sinker): fix if nesting Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinker): fix if nesting Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): warning as error. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix casing. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * changing scenario descriptions for dry-run execution (#2185) * Update README.md (#2181) * Dns and Net v2 metrics test (#2173) * Update README.md * updating kind readme * testing metrics of dns v2 * testing metrics of dns v2 * metrics net handler v2 * net config * fix(maestro): attempt of different approach on idle and active (#2186) * fix(sinker): fix if nesting Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): refactored maestro monitor logic, and add logs to have traces on otel-sinker. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * inserting tag on test scenarios with error status on sink (#2187) * fix(maestro): fix maestro reading events. (#2188) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix maestro reading redis and groups (#2189) * fix(maestro): fix maestro reading redis and groups Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): change approach on apply/delete kubernetes clusters Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): re-added maestro stream. (#2190) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix monitor logic (#2191) * fix(maestroStream): remove duplicate event publishing Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): enhanced logic from monitor. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix iteration to be more performatic and less error prone. (#2192) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * Fix iteration (#2193) * fix(maestro): fix iteration to be more performatic and less error prone. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix nil reference error Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * Orb 694 tests otel migration (#2194) * scenarios to make easier test otel migration * fix(maestro): fix new nil reference error (#2195) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix extract id. (#2196) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): clean up code and create wait mechanism for apply deployments (#2197) * fix(maestro): fix extract id. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): clean up code and enhanced verification of collector apply. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix method calls. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix method calls. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): change from pod, to deployment and added logs for matching items (#2198) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * Small changes on README (#2199) * small changes * Update README.md * fix(redis): Add more logs (#2200) * fix(makefile): clean up docker-compose. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(redis): add debug logs Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(makefile): remove sleep, just retry. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * [FIX] update kind manifests to 1.0.44 (#2203) * fix kind * fix kind * [fix] kind * tests to validate private image (#2202) * Revert "fix(redis): add debug logs" (#2205) * Revert "fix(redis): add debug logs" This reverts commit 44f4b98. * fix(redis): re-add fix on iteration Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(redis): fixing how maestro and sinker handles errors in reading and handling event errors (#2206) * fix(redis): fix breaking out of reading routine because of failure. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(redis): fix breaking out of reading routine because of failure. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(redis): clean up. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix acking messages on error. (#2207) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * add prepare-helm first on run (#2209) * fix(maestro): new configuration handling and creation on kubernetes. (#2211) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): reverting back to file management due to throttling of … (#2212) * fix(maestro): reverting back to file management due to throttling of k8s api. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix reversion Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): remove idle validations. (#2214) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * [ORB-673] Set default path for orb-agent.db (#2213) [ORB-673] Set default path for orb-agent.db (#2213) * WIP: hotfix general css and dataset list table spacings (#2208) * fix(maestro): rollback to complete deployment json (#2216) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * [ORB-669] - Add more changes on README (#2215) * add more changes on README * fix gh organization to orb-community * fix(maestro): remove only changing status in active. to go back from errors like 429. (#2217) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): fix sink deletion propagation to collector and creation event status (#2218) * fix(maestro): remove only changing status in active. to go back from errors like 429. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): alternative fix to delete collectors and create collectors correctly. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> Co-authored-by: Everton H. Taques <97463920+etaques@users.noreply.github.com> * rollback the changes on db file (#2219) * fix(sinker): fix active sink not updating (#2220) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinker): add activity in metric push in sinker, on change from idle/unknown to active (#2221) * fix(sinker): fix active sink not updating Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * Revert "fix(sinker): fix active sink not updating" This reverts commit 5470945. * fix(maestro): alternative fix on sink creation. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(maestro): updating timestamp. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> Co-authored-by: Everton H. Taques <97463920+etaques@users.noreply.github.com> * [FIX] set last activity on redis if sink already is active (#2222) * fix active * disable go routines to test * Update streams.go * add logs * fix(maestro): add subgroup to sinker and fix old timestamped logs interfering with status (#2224) * fix(maestro): ignore old messages, set as active. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinker): added different group for sinker when otel is enabled. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinker): added different group for sinker when otel is enabled. Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix(sinker): don't fetch logs older than 5 minutes. (#2225) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * fix install kubectl (#2226) * fix install kubectl * Update Makefile * fix(maestro): fix deletion. (#2227) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * feat(maestro): fix subscription (#2229) Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> * [ORB-689] sinks status synchronization (#2231) * Update monitor.go * Update kubecontrol.go * change to 10 minutes to be idle * set to change if idle be active if have activity * back to active after idle * Update kubecontrol.go * increase idle time to 15 minutes * fix idle * fix sinker activity * add changes * changes * add changes * add changes * add changes * add changes * add changes * add changes * add changes * add changes * add changes * add changes * add changes * increasing timeout for test sink status (#2233) --------- Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com> Co-authored-by: manrodrigues <manrodriguessilva@gmail.com> Co-authored-by: Luiz Henrique Pegoraro <luiz.pegoraro@encora.com> Co-authored-by: Mariana Cavalcante <mariana.cavalcante@encora.com> Co-authored-by: Guilhermo Pazuch <1490938+gpazuch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luiz Pegoraro luiz.pegoraro@encora.com