Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sinker break again #2032

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

lpegoraro
Copy link
Contributor

No description provided.

Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com>
Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com>
@lpegoraro lpegoraro self-assigned this Nov 18, 2022
Copy link
Contributor

@manrodrigues manrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Base: 60.21% // Head: 60.21% // No change to project coverage 👍

Coverage data is based on head (af9085c) compared to base (1837962).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2032   +/-   ##
========================================
  Coverage    60.21%   60.21%           
========================================
  Files           70       70           
  Lines         4931     4931           
========================================
  Hits          2969     2969           
  Misses        1962     1962           
Impacted Files Coverage Δ
sinker/otel/orbreceiver/otlp.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lpegoraro lpegoraro merged commit f397266 into orb-community:develop Nov 18, 2022
@lpegoraro lpegoraro deleted the fix/sinker_break_again branch November 23, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants