Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/metrics interpolation #2030

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

lpegoraro
Copy link
Contributor

No description provided.

Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com>
…tributes.

Signed-off-by: Luiz Pegoraro <luiz.pegoraro@encora.com>
@lpegoraro lpegoraro requested a review from leoparente November 18, 2022 17:30
@lpegoraro lpegoraro self-assigned this Nov 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Base: 60.38% // Head: 60.21% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (adafe00) compared to base (db13479).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2030      +/-   ##
===========================================
- Coverage    60.38%   60.21%   -0.18%     
===========================================
  Files           70       70              
  Lines         4917     4931      +14     
===========================================
  Hits          2969     2969              
- Misses        1948     1962      +14     
Impacted Files Coverage Δ
agent/otel/otlpmqttexporter/otlp.go 7.27% <0.00%> (-0.42%) ⬇️
sinker/otel/orbreceiver/otlp.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpegoraro lpegoraro merged commit 1837962 into orb-community:develop Nov 18, 2022
@lpegoraro lpegoraro deleted the fix/metrics_interpolation branch November 23, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants