Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Sinker state checker for otel #1958

Merged
merged 9 commits into from
Nov 2, 2022
Merged

[Fix] Sinker state checker for otel #1958

merged 9 commits into from
Nov 2, 2022

Conversation

etaques
Copy link
Contributor

@etaques etaques commented Nov 2, 2022

No description provided.

@etaques etaques requested a review from mclcavalcante November 2, 2022 22:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Base: 61.88% // Head: 62.74% // Increases project coverage by +0.85% 🎉

Coverage data is based on head (a582cc2) compared to base (639f544).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1958      +/-   ##
===========================================
+ Coverage    61.88%   62.74%   +0.85%     
===========================================
  Files           70       18      -52     
  Lines         4773      859    -3914     
===========================================
- Hits          2954      539    -2415     
+ Misses        1819      320    -1499     
Impacted Files Coverage Δ
maestro/config/config_builder.go
fleet/api/http/logging.go
maestro/config/types.go
policies/api/http/endpoint.go
fleet/comms.go
fleet/api/http/endpoint.go
fleet/agents.go
sinker/otel/kafkafanoutexporter/pdata_marshaler.go
fleet/postgres/database.go
sinker/otel/orbreceiver/encoder.go
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@etaques etaques changed the title Sinker test [Fix] Sinker for otel Nov 2, 2022
Copy link
Contributor

@mclcavalcante mclcavalcante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etaques etaques changed the title [Fix] Sinker for otel [Fix] Sinker state checker for otel Nov 2, 2022
@etaques etaques merged commit 02cb787 into develop Nov 2, 2022
@etaques etaques deleted the sinker-test branch November 2, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants