Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datasets: disable group field change in dataset #1589

Closed
manrodrigues opened this issue Jul 27, 2022 · 2 comments
Closed

Datasets: disable group field change in dataset #1589

manrodrigues opened this issue Jul 27, 2022 · 2 comments
Assignees
@gpazuch
Labels
bug Something isn't working orb-ui Anything related to the angular UI p1 An issue that needs to be addressed fast. Such an issue that blocks the majority of users

Comments

@manrodrigues
Copy link
Contributor

Since editing the group in the dataset is not allowed, this field must not be enabled for change.

image.png
@manrodrigues manrodrigues added bug Something isn't working orb-ui Anything related to the angular UI p2 An issue that needs to be addressed on a reasonable timescale labels Jul 27, 2022
@manrodrigues manrodrigues added p1 An issue that needs to be addressed fast. Such an issue that blocks the majority of users and removed p2 An issue that needs to be addressed on a reasonable timescale labels Nov 7, 2022
@manrodrigues
Copy link
Contributor Author

I"m changing to P1 because it gives a worng impression that the dataset editing process is incorrect.. we need to insert a message advising the users to remove the dataset because the group can't be changed

@gpazuch gpazuch self-assigned this Dec 16, 2022
gpazuch added a commit to gpazuch/orb that referenced this issue Dec 19, 2022
@gpazuch
fix(ui): orb-community#1589 dataset is agent group is not editable
862a42d
gpazuch added a commit that referenced this issue Dec 20, 2022
@gpazuch
fix(ui): #1589 dataset must not allow agent group editing
ed34aba
gpazuch added a commit that referenced this issue Dec 20, 2022
@gpazuch
fix(ui): #1589 dataset must not allow agent group editing (#2103)
dd601ef
@manrodrigues
Copy link
Contributor Author

ok

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gpazuch gpazuch

Labels
bug Something isn't working orb-ui Anything related to the angular UI p1 An issue that needs to be addressed fast. Such an issue that blocks the majority of users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gpazuch @manrodrigues