Conversion between a Config and a ConfigFile #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lswith
requested review from
thomastaylor312,
bacongobbler and
flavio
as code owners
flavio
reviewed
May 9, 2023
There was a problem hiding this comment.
I'm in favor of this change, I just have some questions about the error being raised by the new try_from.
@bacongobbler, @thomastaylor312: what do you think about that?
Signed-off-by: Luke Swithenbank <lswith@users.noreply.github.com>
Signed-off-by: Luke Swithenbank <lswith@users.noreply.github.com>
Provide a dedicated error type to address Config conversion errors. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
|
I've rebased against the main branch and addressed some conflicts |
|
merged, sorry for the delay |
Merged
flavio
added a commit
to flavio/rust-oci-client
that referenced
this pull request
Nov 24, 2023
What's Changed: * client: Fix failed to pull ubuntu image from docker.io by @arronwy in oras-project#67 * Update rstest requirement from 0.16.0 to 0.17.0 by @dependabot in oras-project#70 * Bump actions/checkout from 3.3.0 to 3.4.0 by @dependabot in oras-project#69 * Bump actions/checkout from 3.4.0 to 3.5.0 by @dependabot in oras-project#73 * Change the visibility of `OciEnvelop.errors` to `pub` by @linyinfeng in oras-project#71 * Bump actions/checkout from 3.5.0 to 3.5.2 by @dependabot in oras-project#74 * make pushes concurrent and limit pull concurrency by @dicej in oras-project#72 * Update default `docker.io` registry by @radu-matei in oras-project#81 * Fix: Expose HTTP errors when pulling layers by @jsoverson in oras-project#82 * client: Return Stream for async_pull_blob API by @arronwy in oras-project#83 * chore(deps): Bump actions/checkout from 3.5.2 to 3.5.3 by @dependabot in oras-project#85 * fix(CI): address warnings of cargo deny by @flavio in oras-project#84 * consider ARCH as ppc64le when rust arch is powerpc64 by @Amulyam24 in oras-project#86 * chore(deps): Update rstest requirement from 0.17.0 to 0.18.1 by @dependabot in oras-project#88 * add optional artifactType to image manifest for oci v1.1 by @devigned in oras-project#89 * Higher-ranked lifetime error workaround by @linyinfeng in oras-project#90 * chore(deps): Bump actions/checkout from 3.5.3 to 3.6.0 by @dependabot in oras-project#91 * chore(deps): Bump actions/checkout from 3.6.0 to 4.0.0 by @dependabot in oras-project#92 * chore(deps): Bump actions/checkout from 4.0.0 to 4.1.0 by @dependabot in oras-project#94 * Improved Push Logic by @rbbl-dev in oras-project#93 * Update the configfile to match the oci v1 spec by @lswith in oras-project#77 * Conversion between a Config and a ConfigFile by @lswith in oras-project#76 * Enhance client to push blobs, mount blobs, and push raw manifests by @aochagavia in oras-project#66 * fix: bring back workaround for rustc by @flavio in oras-project#95 * implemented method to list tags by @rbbl-dev in oras-project#80 * feat(config.rs): add OS type for WASI Preview 1 by @vdice in oras-project#99 * chore(deps): Bump actions/checkout from 4.1.0 to 4.1.1 by @dependabot in oras-project#100 * chore(deps): Update testcontainers requirement from 0.14 to 0.15 by @dependabot in oras-project#96 * feat: return auth token from Client::auth by @mattarnoatibm in oras-project#105 Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the TryFrom for a client::Config so that it can be parsed back into a ConfigFile.
This feature is useful when pulling images from a registry, so that the metadata recieved can be viewed.