Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cov): make unit tests cover more #905

Merged
merged 2 commits into from
Mar 26, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Mar 25, 2023

What this PR does / why we need it:
This PR introduces no change but only does some code clean and makes code coverage looks better.

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2023

Codecov Report

Merging #905 (e8277d7) into main (660d167) will increase coverage by 0.61%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   67.17%   67.79%   +0.61%     
==========================================
  Files          21       22       +1     
  Lines         850      860      +10     
==========================================
+ Hits          571      583      +12     
+ Misses        233      232       -1     
+ Partials       46       45       -1     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not a table test fan, but that is just opinion.

internal/graph/graph_test.go Show resolved Hide resolved
internal/crypto/certificate_test.go Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 67dca8e into oras-project:main Mar 26, 2023
qweeah added a commit to qweeah/oras that referenced this pull request Mar 27, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants