test(e2e): take registry logs when e2e fails #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
requested review from
deitch,
jdolitsky,
sajayantony,
shizhMSFT,
SteveLasker and
TerryHowe
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #830 +/- ##
=======================================
Coverage 63.50% 63.50%
=======================================
Files 21 21
Lines 844 844
=======================================
Hits 536 536
Misses 265 265
Partials 43 43 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
changed the title
|
LGTM. Thanks for the contribution. |
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
TerryHowe
reviewed
Feb 21, 2023
Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the last 200 lines of registry logs when the Ginkgo test run fails with any error.
Raising this since we had an unexpected error happened on distribution side during E2E run (see logs). Since there is no distribution logs taken, it's very hard to trouble-shoot the failed E2E case. Adding this PR so we can have sth to look into when such random flaky error comes next time.