feat: support artifact discovering in OCI image layout #765
Conversation
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #765 +/- ##
==========================================
- Coverage 63.86% 61.54% -2.32%
==========================================
Files 19 20 +1
Lines 714 801 +87
==========================================
+ Hits 456 493 +37
- Misses 225 268 +43
- Partials 33 40 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
qweeah
changed the title
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
This reverts commit bf77ecc. Signed-off-by: Billy Zha <jinzha1@microsoft.com>
This reverts commit f0fc6b8. Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
cmd/oras/discover.go
Outdated
| var fetched []byte | ||
| if rc, err := target.Fetch(ctx, node); err != nil { | ||
| return nil, err | ||
| } else { |
There was a problem hiding this comment.
The else enclosing can be deleted.
There was a problem hiding this comment.
If else is deleted, then rc will be undefined.
There was a problem hiding this comment.
It reminds me that I can actually use https://pkg.go.dev/oras.land/oras-go/v2#FetchBytes to avoid reading from rc myself
There was a problem hiding this comment.
rc is not deferred to be closed.
cmd/oras/discover.go
Outdated
| }) | ||
| if err != nil { | ||
| return nil, err | ||
| func fetchReferrers(ctx context.Context, target oras.ReadOnlyGraphTarget, desc ocispec.Descriptor, artifactType string) ([]ocispec.Descriptor, error) { |
There was a problem hiding this comment.
Can we put this function into a package so that we can have unit tests?
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
This PR adds OCI image layout support for
oras discovercommand and resolves #760. The UX is consistent with remote registry and looks like below:Signed-off-by: Billy Zha jinzha1@microsoft.com