feat!: support configurable subject pulling #689
Conversation
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
cmd/oras/pull.go
Outdated
| @@ -84,6 +89,7 @@ Example - Pull all files with concurrency level tuned: | |||
|
|
|||
| cmd.Flags().BoolVarP(&opts.KeepOldFiles, "keep-old-files", "k", false, "do not replace existing files when pulling, treat them as errors") | |||
| cmd.Flags().BoolVarP(&opts.PathTraversal, "allow-path-traversal", "T", false, "allow storing files out of the output directory") | |||
| cmd.Flags().BoolVarP(&opts.IncludeSubject, "include-subject", "", false, "download files recursively from subject images/artifacts") | |||
There was a problem hiding this comment.
| cmd.Flags().BoolVarP(&opts.IncludeSubject, "include-subject", "", false, "download files recursively from subject images/artifacts") | |
| cmd.Flags().BoolVarP(&opts.IncludeSubject, "include-subject", "", false, "recursively pull the subject of artifacts") |
Codecov Report
@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 72.12% 72.12%
=======================================
Files 14 14
Lines 513 513
=======================================
Hits 370 370
Misses 114 114
Partials 29 29 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cmd/oras/pull.go
Outdated
| @@ -84,6 +89,7 @@ Example - Pull all files with concurrency level tuned: | |||
|
|
|||
| cmd.Flags().BoolVarP(&opts.KeepOldFiles, "keep-old-files", "k", false, "do not replace existing files when pulling, treat them as errors") | |||
| cmd.Flags().BoolVarP(&opts.PathTraversal, "allow-path-traversal", "T", false, "allow storing files out of the output directory") | |||
| cmd.Flags().BoolVarP(&opts.IncludeSubject, "include-subject", "", false, "download files recursively the subject of artifacts") | |||
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
|
Let's merge after the release of |
|
I was hoping this would be there in the next release. The pulling of all related content is a bit confusing to be honest when you want to just pull the attached SBOM. |
@sajayantony Agree, I think this PR is a breaking change that has changed the default behavior of |
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
|
Merging to |
Resolves oras-project#681 Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Resolves #681
Signed-off-by: Billy Zha jinzha1@microsoft.com