feat: support delete a blob from a remote registry

[lizMSFT]

Add a command to delete a blob from a remote registry

Resolves: #474
Signed-off-by: Zoey Li zoeyli@microsoft.com

[Wwwsylvia]

LGTM

[qweeah]

We need to wrap all the err returning from deleteBlob() to make error message more readable to user.

e.g.

if err = repo.Delete(ctx, desc); err != nil {
    return fmt.Errorf("failed to delete %s: %w", opts.targetRef, err)
}

[shizhMSFT]

It's better to have a confirmation before deletion. Also, it is good to display a warning on the implication of deleting a blob.

Again, have you tried with those delete-disabled registries? What does the error message look like?

[lizMSFT]

Hi @shizhMSFT,

I tried delete a blob from a delete-disabled registry, below is the current error message:
Error: failed to delete localhost:12900/0818hello@sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855: DELETE "http://localhost:12900/v2/0818hello/blobs/sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855": unexpected status code 405: unsupported: The operation is unsupported.
I'm wondering if we should provide more specific error message for this kind of error? thanks

cc @yuehaoliang-microsoft

[codecov-commenter]

Codecov Report

Merging #493 (d057c64) into main (551aca4) will decrease coverage by 2.53%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   71.37%   68.83%   -2.54%     
==========================================
  Files          12       13       +1     
  Lines         489      507      +18     
==========================================
  Hits          349      349              
- Misses        112      130      +18     
  Partials       28       28              

Impacted Files	Coverage Δ
cmd/oras/internal/option/confirmation.go	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[yuehaoliang]

Hi @shizhMSFT,

I tried delete a blob from a delete-disabled registry, below is the current error message: Error: failed to delete localhost:12900/0818hello@sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855: DELETE "http://localhost:12900/v2/0818hello/blobs/sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855": unexpected status code 405: unsupported: The operation is unsupported. I'm wondering if we should provide more specific error message for this kind of error? thanks

cc @yuehaoliang-microsoft

I've seen this error when I previously used oras/distribution without enabling the deletion. Maybe we can have a more clear error message to let users know it the registry server side which they use doesn't accept the delete operation. At least, unexpected status code 405: unsupported: The operation is unsupported this message tells users their deletion is unsuccessful.

[shizhMSFT]

Hi @shizhMSFT,
I tried delete a blob from a delete-disabled registry, below is the current error message: Error: failed to delete localhost:12900/0818hello@sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855: DELETE "http://localhost:12900/v2/0818hello/blobs/sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855": unexpected status code 405: unsupported: The operation is unsupported. I'm wondering if we should provide more specific error message for this kind of error? thanks
cc @yuehaoliang-microsoft

I've seen this error when I previously used oras/distribution without enabling the deletion. Maybe we can have a more clear error message to let users know it the registry server side which they use doesn't accept the delete operation. At least, unexpected status code 405: unsupported: The operation is unsupported this message tells users their deletion is unsuccessful.

@Wwwsylvia, we should support this in the oras-go: oras-project/oras-go#317.

[shizhMSFT]

LGTM