Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mTLS options #1319

Merged
merged 1 commit into from
Apr 16, 2024
Merged

feat: add mTLS options #1319

merged 1 commit into from
Apr 16, 2024

Conversation

sabre1041
Copy link
Contributor

Adds support for mTLS to remote registries

Resolves #491

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@codecov Codecov
Copy link

codecov bot commented Apr 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.55%. Comparing base (67ee100) to head (8d1ee20).

Files Patch % Lines
cmd/oras/internal/option/remote.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
- Coverage   84.56%   84.55%   -0.02%     
==========================================
  Files         103      103              
  Lines        3668     3677       +9     
==========================================
+ Hits         3102     3109       +7     
- Misses        337      338       +1     
- Partials      229      230       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah qweeah changed the title Added mTLS options feat: add mTLS options Apr 7, 2024
qweeah
qweeah requested changes Apr 9, 2024
View reviewed changes
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Show resolved Hide resolved
qweeah
qweeah approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT reviewed Apr 15, 2024
View reviewed changes
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote_test.go Show resolved Hide resolved
cmd/oras/internal/option/remote_test.go Outdated Show resolved Hide resolved
@shizhMSFT shizhMSFT added this to the v1.2.0 milestone Apr 16, 2024
shizhMSFT
shizhMSFT approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/oras/internal/option/remote_test.go Show resolved Hide resolved
@sabre1041
Added mTLS options
8d1ee20 
Signed-off-by: Andrew Block <andy.block@gmail.com>
shizhMSFT
shizhMSFT approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 8b5c576 into oras-project:main Apr 16, 2024
8 checks passed
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
@sabre1041 @FeynmanZhou
feat: add mTLS options (oras-project#1319)
d41f6f6 
Signed-off-by: Andrew Block <andy.block@gmail.com>
@qweeah qweeah mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeynmanZhou FeynmanZhou FeynmanZhou left review comments

@qweeah qweeah qweeah approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0-rc.1
Development

Successfully merging this pull request may close these issues.

X509 Authentication with OCI registry
5 participants
@sabre1041 @TerryHowe @qweeah @shizhMSFT @FeynmanZhou