Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly print tree for oras discover #1005

Merged
merged 7 commits into from
Jul 6, 2023

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Jul 5, 2023

What this PR does / why we need it:

  • Properly print tree for oras discover
  • Remove the dependency of github.com/need-being/go-tree, which is no longer maintained and does not have any tests

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1003

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #1005 (9064314) into main (42650e5) will increase coverage by 0.01%.
The diff coverage is 78.94%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
+ Coverage   81.14%   81.16%   +0.01%     
==========================================
  Files          55       57       +2     
  Lines        2848     2904      +56     
==========================================
+ Hits         2311     2357      +46     
- Misses        367      373       +6     
- Partials      170      174       +4     
Impacted Files Coverage Δ
internal/tree/printer.go 60.00% <60.00%> (ø)
cmd/oras/root/discover.go 85.21% <100.00%> (ø)
internal/tree/node.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
Copy link
Contributor Author

Note: @need-being is my personal GitHub account

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 34390f9 into oras-project:main Jul 6, 2023
5 checks passed
@shizhMSFT shizhMSFT deleted the tree branch July 6, 2023 05:46
shizhMSFT added a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper verbose output of oras discover -o tree
4 participants