Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove reference to media-type option that was removed #89

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

TerryHowe
Copy link
Member

This issue has merged, no need to mention it.

Closes: #44

Signed-off-by: Terry Howe tlhowe@amazon.com

Signed-off-by: Terry Howe <tlhowe@amazon.com>
@TerryHowe TerryHowe changed the title Remove reference to media-type option that was removed fix: Remove reference to media-type option that was removed Feb 4, 2023
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @TerryHowe

@vsoch
Copy link
Contributor

vsoch commented Mar 16, 2023

If there is some reason for understanding these command flags, perhaps (instead of the link to the issue) it should be explained?

@TerryHowe
Copy link
Member Author

If there is some reason for understanding these command flags, perhaps (instead of the link to the issue) it should be explained?

This is documenting a breaking change from several releases ago, this should be documented in the change log, not here.

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou FeynmanZhou merged commit 8b6cc05 into oras-project:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--media-type is deprecated in 0.13.0 but still in web doc
4 participants