Skip to content

Commit

Permalink
core: add missing prefix property to auth backend (#165)
Browse files Browse the repository at this point in the history
* core: add missing prefix property to auth backend

ref #164 (comment)

Signed-off-by: tarilabs <matteo.mortari@gmail.com>
  • Loading branch information
tarilabs authored Oct 19, 2024
1 parent 36ef98a commit 6df6127
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and **Merged pull requests**. Critical items to know are:
The versions coincide with releases on pip. Only major versions will be released as tags on Github.

## [0.0.x](https://github.com/oras-project/oras-py/tree/main) (0.0.x)
- add missing prefix property to auth backend (0.2.23)
- allow for filepaths to include `:` (0.2.22)
- release request (0.2.21)
- add missing basic auth data for request token function in token auth backend (0.2.2)
Expand Down
3 changes: 2 additions & 1 deletion oras/auth/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ class AuthenticationException(Exception):
pass


def get_auth_backend(name="token", session=None, **kwargs):
def get_auth_backend(name="token", session=None, insecure=False, **kwargs):
backend = auth_backends.get(name)
if not backend:
raise ValueError(f"Authentication backend {backend} is not known.")
backend = backend(**kwargs)
backend.session = session or requests.Session()
backend.prefix = "http" if insecure else "https"
return backend
1 change: 1 addition & 0 deletions oras/auth/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class AuthBackend:

def __init__(self, *args, **kwargs):
self._auths: dict = {}
self.prefix: str = "https"

def get_auth_header(self):
raise NotImplementedError
Expand Down
2 changes: 1 addition & 1 deletion oras/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def __init__(
self.session.cookies.set_policy(DefaultCookiePolicy(allowed_domains=[]))

# Get custom backend, pass on session to share
self.auth = oras.auth.get_auth_backend(auth_backend, self.session)
self.auth = oras.auth.get_auth_backend(auth_backend, self.session, insecure)

def __repr__(self) -> str:
return str(self)
Expand Down
2 changes: 1 addition & 1 deletion oras/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
__copyright__ = "Copyright The ORAS Authors."
__license__ = "Apache-2.0"

__version__ = "0.2.22"
__version__ = "0.2.23"
AUTHOR = "Vanessa Sochat"
EMAIL = "vsoch@users.noreply.github.com"
NAME = "oras"
Expand Down

0 comments on commit 6df6127

Please sign in to comment.