Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't run lint from test-ci #11

Open
wants to merge 5 commits into
base: orangemocha-reconcile-ci2
Choose a base branch
from

Conversation

orangemocha
Copy link
Owner

Since we will run linting before compiling or testing there's no
need to run it as part of the ci testing.

Cherry-picked from nodejs/node@8d8a26e
Original commit metadata follows:
PR-URL: nodejs/node#1965
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Revewied-By: Evan Lucas evanlucas@me.com

orangemocha and others added 5 commits June 9, 2015 16:11
This is a minimal effort to support test output written both to
stdout and file in order to get our buildbots understanding
test output.

Cherry picked from jbergstroem/node@3194073
Original commit message follows:
  PR-URL: nodejs/node#934
  Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Conflicts:
	tools/test.py
Snapshots speed up start-up by a few milliseconds but are potentially
dangerous because of the fixed hash seed that is used for strings and
dictionaries, making collision denial-of-service attacks possible.

Release builds on iojs.org have snapshots disabled but source builds
did not, until now.

The risk for individual source builds is low; the binary gets a random
32 bits hash seed that should be hard to guess by an external attacker.

It's when binaries are distributed by, for example, a distro vendor
that the fixed hash seed becomes a vulnerability, because then it's
possible to target a large group of people at once.

People that really need the faster start-up time can use the new
--with-snapshot configure flag.

Cherry picked from bnoordhuis/io.js@4f68369
Original commit metadata below:
  PR-URL: nodejs/node#585
  Reviewed-By: Bert Belder <bertbelder@gmail.com>
  Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
  Reviewed-By: Rod Vagg <rod@vagg.org>
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <rod@vagg.org>
Since we will run linting before compiling or testing there's no
need to run it as part of the ci testing.

Cherry-picked from nodejs/node@8d8a26e
Original commit metadata follows:
  PR-URL: nodejs/node#1965
  Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  Revewied-By: Evan Lucas <evanlucas@me.com>
orangemocha pushed a commit that referenced this pull request Jun 29, 2015
Since we will run linting before compiling or testing there's no
need to run it as part of the ci testing.

Cherry-picked from nodejs/node@8d8a26e
Original commit metadata follows:
  PR-URL: nodejs/node#1965
  Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  Revewied-By: Evan Lucas <evanlucas@me.com>

Reviewed-By: Dummy Reviewer <dummy@reviewer.org>
PR-URL: #11
orangemocha pushed a commit that referenced this pull request Jul 7, 2015
Since we will run linting before compiling or testing there's no
need to run it as part of the ci testing.

Cherry-picked from nodejs/node@8d8a26e
Original commit metadata follows:
  PR-URL: nodejs/node#1965
  Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  Revewied-By: Evan Lucas <evanlucas@me.com>

Reviewed-By: Dummy Reviewer <dummy@reviewer.org>
PR-URL: #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants