UI requests #20
Merged
UI requests #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
g-francesca
reviewed
Jul 31, 2024
| @@ -50,18 +50,21 @@ export class ChatService { | |||
| } | |||
|
|
|||
| // TODO: WE may want to reveive ask props as a Service prop instead of enforcing it here | |||
| return this.answerSession.ask({ term: term, related: { howMany: 3, format: 'question' } }).catch((error) => { | |||
| chatContext.interactions = chatContext.interactions.map((interaction, index) => { | |||
There was a problem hiding this comment.
@rjborba not sure about this deletion here
g-francesca
reviewed
Jul 31, 2024
| placeholder={this.placeholder} | ||
| sourceBaseUrl={this.sourceBaseUrl} | ||
| sourcesMap={this.sourcesMap} | ||
| style={{ minHeight: '400px' }} |
There was a problem hiding this comment.
Is this to address the request about having the answers/clear chat fixed on top? If so, I'm trying a different solution (I explained on Figma). If it works, it should be safer for general component purposes.
There was a problem hiding this comment.
This thing was a mistake hahaha
I just added to test the behavior of the container without needing to make questions.
I should remove it :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.figma.com/design/p38rGBjH8OqgdI6Wn7Vk1t/Search-Box---AS-MODAL?node-id=1131-2293&t=5AlP09MVpB87xsVY-0