Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/return error if exceed slippage #42

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Hotfix/return error if exceed slippage #42

merged 4 commits into from
Mar 6, 2024

Conversation

trung2891
Copy link
Member

  • Throw error if entry price exceeds slippage
  • Emits event that the number of tokens filled in a matching round

@trung2891 trung2891 requested a review from ducphamle2 March 6, 2024 02:25
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ducphamle2
ducphamle2 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@ducphamle2 ducphamle2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ducphamle2 ducphamle2 merged commit 1b5dd26 into main Mar 6, 2024
1 check passed
@ducphamle2 ducphamle2 deleted the hotfix/return-error-if-exceed-slippage branch March 6, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducphamle2 ducphamle2 ducphamle2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trung2891 @ducphamle2