Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for PR #7654, Fixing the issue #182, Signature error when hovering over constructor #238

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

subhash-arabhi
Copy link
Member

Back-porting the PR #7654

Signed-off-by: Subhash Arabhi <subhashsubbu636@gmail.com>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 14, 2024
Achal1607
Achal1607 previously approved these changes Aug 14, 2024
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks

@Achal1607 Achal1607 linked an issue Aug 14, 2024 that may be closed by this pull request
sid-srini
sid-srini previously approved these changes Aug 14, 2024
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved merge conflicts

Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved merge conflicts

@sid-srini sid-srini merged commit 8693aa0 into oracle:main Aug 14, 2024
3 checks passed
@sid-srini sid-srini added this to the JVSC 22.1.2 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show constructor signature in hover information
3 participants