Ensure that the context is set throughout the request lifecycle #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Context to RequestContext: - added a method "runInScope" to invoke Contexts.runInContext + logging - added "in-scope" short-hand methods for publisher.fail, publisher.emit, publisher.complete - removed "publisher()" to force the use of the in-scope short-hand methods Request only creates a new context if Contexts.context() is empty - NOT throwing an exception as that would impact Routing.route which is a public API Added a unit test
spericas
approved these changes
Apr 1, 2021
aseovic
pushed a commit
to aseovic/helidon
that referenced
this pull request
Apr 26, 2021
…don-io#2898) * Ensure that the context is set throughout the request lifecycle. Added Context to RequestContext: - added a method "runInScope" to invoke Contexts.runInContext + logging - added "in-scope" short-hand methods for publisher.fail, publisher.emit, publisher.complete - removed "publisher()" to force the use of the in-scope short-hand methods Request only creates a new context if Contexts.context() is empty - NOT throwing an exception as that would impact Routing.route which is a public API Added a unit test * Update TestClient to setup the context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2838