Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the context is set throughout the request lifecycle #2898

Merged
merged 6 commits into from
Apr 1, 2021
Merged

Ensure that the context is set throughout the request lifecycle #2898

merged 6 commits into from
Apr 1, 2021

Commits on Mar 31, 2021

  1. Ensure that the context is set throughout the request lifecycle. 

    Added Context to RequestContext:
 - added a method "runInScope" to invoke Contexts.runInContext + logging
 - added "in-scope" short-hand methods for publisher.fail, publisher.emit, publisher.complete
 - removed "publisher()" to force the use of the in-scope short-hand methods
Request only creates a new context if Contexts.context() is empty
 - NOT throwing an exception as that would impact Routing.route which is a public API
Added a unit test
    @romain-grecourt
    romain-grecourt committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    4a125ce View commit details
    Browse the repository at this point in the history

  2. avoid using String.format

    @romain-grecourt
    romain-grecourt committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    5fa8330 View commit details
    Browse the repository at this point in the history

  3. update TestClient to setup the context

    @romain-grecourt
    romain-grecourt committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    6324f37 View commit details
    Browse the repository at this point in the history

  4. rename publisherPh to publisherRef now that publisher is a local vari… 

    …able
    @romain-grecourt
    romain-grecourt committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    8572b72 View commit details
    Browse the repository at this point in the history

  5. remove un-necessary formatting changes

    @romain-grecourt
    romain-grecourt committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    02eac27 View commit details
    Browse the repository at this point in the history

  6. make the test class package private instead of public

    @romain-grecourt
    romain-grecourt committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    233643a View commit details
    Browse the repository at this point in the history