Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Session.getDatasourceLogin() instead of Session.getLogin() in CDISEPlatform.java #2263

Merged
merged 4 commits into from
Aug 17, 2020
Merged

Use Session.getDatasourceLogin() instead of Session.getLogin() in CDISEPlatform.java #2263

merged 4 commits into from
Aug 17, 2020

Conversation

ljnelson
Copy link
Member

Signed-off-by: Laird Nelson laird.nelson@oracle.com

…SEPlatform.java

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson ljnelson self-assigned this Aug 14, 2020
@ljnelson ljnelson linked an issue Aug 14, 2020 that may be closed by this pull request
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for tiny nit on the copyright notice.

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson ljnelson merged commit 45a70b1 into helidon-io:master Aug 17, 2020
@ljnelson ljnelson deleted the fix-databaselogin branch August 17, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CDISEPlatform uses getLogin() instead of getDatasourceLogin()
2 participants