Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDISEPlatform uses getLogin() instead of getDatasourceLogin() #2262

Closed
ljnelson opened this issue Aug 14, 2020 · 0 comments · Fixed by #2263
Closed

CDISEPlatform uses getLogin() instead of getDatasourceLogin() #2262

ljnelson opened this issue Aug 14, 2020 · 0 comments · Fixed by #2263
Assignees
@ljnelson
Labels
jpa/jta P4 task To do

Comments

@ljnelson
Copy link
Member

The CDISEPlatform class uses Session#getLogin():

https://github.com/oracle/helidon/blob/19b51752a99ea7b3f948a69bf55f35ecd2507a84/integrations/cdi/eclipselink-cdi/src/main/java/io/helidon/integrations/cdi/eclipselink/CDISEPlatform.java#L228

This is an obsolete call and should be replaced with getDatasourceLogin().

See also: https://stackoverflow.com/questions/63315494/helidon-mp-validationexception-in-injecting-mongodb-entitymanager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljnelson ljnelson

Labels
jpa/jta P4 task To do
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Session.getDatasourceLogin() instead of Session.getLogin() in CDISEPlatform.java
1 participant
@ljnelson