Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadableByteChannelPublisher executor leak #1924

Merged

Conversation

tomas-langer
Copy link
Member

And related fixes.

Resolves #1835

@tomas-langer tomas-langer added the 2.x Issues for 2.x version branch label Jun 2, 2020
@tomas-langer tomas-langer self-assigned this Jun 2, 2020
@tomas-langer tomas-langer marked this pull request as draft June 2, 2020 18:01
romain-grecourt
romain-grecourt previously approved these changes Jun 3, 2020
@tomas-langer
Copy link
Member Author

/trigger

…ized constructor when pre-loaded.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Using a builder and static factory methods
Deprecated public constructor

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
- renamed methods in IoMulti
- RetrySchema now sent around only when customized
- Deprecated old methods and classes

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer force-pushed the 1835-byte-channel-executor-leak branch from e5352f0 to 5d7872b Compare June 4, 2020 08:47
@tomas-langer tomas-langer marked this pull request as ready for review June 4, 2020 08:50
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Fixed compilation issue caused by refactoring.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
danielkec
danielkec previously approved these changes Jun 4, 2020
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer merged commit afd3920 into helidon-io:master Jun 5, 2020
@tomas-langer tomas-langer deleted the 1835-byte-channel-executor-leak branch June 5, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadableByteChannelPublisher keeps executor service forever (and scheduled)
3 participants