Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadableByteChannelPublisher keeps executor service forever (and scheduled) #1835

Closed
tomas-langer opened this issue May 20, 2020 · 1 comment · Fixed by #1924
Closed

ReadableByteChannelPublisher keeps executor service forever (and scheduled) #1835

tomas-langer opened this issue May 20, 2020 · 1 comment · Fixed by #1924
Assignees
@tomas-langer
Labels
1.x Issues for 1.x version branch 2.x Issues for 2.x version branch bug Something isn't working P1 reactive Reactive streams and related components
Milestone
2.0.0

Comments

@tomas-langer
Copy link
Member

  1. The executor service is not daemon, so it keeps the JVM running (line 194)
  2. The executor service is not shut down, so it stays around forever - this is a memory leak

We should:

  • provide option to use an external executor service
  • provide a thread factory so the threads are daemon
  • if our own instance is used, shut it down once the last bytes are written
@tomas-langer tomas-langer added bug Something isn't working reactive Reactive streams and related components labels May 20, 2020
@tomas-langer
Copy link
Member Author

If this class would be moved to another package, leave a copy and mark it deprecated, as it is used by Jersey Helidon client connector.
We can remove it once new version of Jersey is released using the new API

@m0mus m0mus added this to the 2.0.0 milestone May 21, 2020
@m0mus m0mus added 1.x Issues for 1.x version branch 2.x Issues for 2.x version branch P1 labels May 21, 2020
@tomas-langer tomas-langer self-assigned this Jun 2, 2020
@tomas-langer tomas-langer mentioned this issue Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomas-langer tomas-langer

Labels
1.x Issues for 1.x version branch 2.x Issues for 2.x version branch bug Something isn't working P1 reactive Reactive streams and related components
Projects
Backlog
Archived in project
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

ReadableByteChannelPublisher executor leak tomas-langer/helidon
2 participants
@m0mus @tomas-langer