Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reactive] Fix Multi.timeout onSubscribe/schedule race violating the spec #1674

Merged
merged 1 commit into from
Apr 22, 2020
Merged

[Reactive] Fix Multi.timeout onSubscribe/schedule race violating the spec #1674

merged 1 commit into from
Apr 22, 2020

Conversation

akarnokd
Copy link
Collaborator

The fix involves deferring the downstream requests until the first timeout is started, then subscribing to the upstream and relaying the accumulated requests.

(SingleTimeout already operates this way.)

@akarnokd akarnokd mentioned this pull request Apr 21, 2020
Closed
@danielkec danielkec self-assigned this Apr 22, 2020
@danielkec danielkec added the reactive Reactive streams and related components label Apr 22, 2020
@danielkec danielkec added this to the 2.0.0 milestone Apr 22, 2020
danielkec
danielkec approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@danielkec danielkec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@danielkec danielkec merged commit c769d8e into helidon-io:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkec danielkec danielkec approved these changes

Assignees

@danielkec danielkec

Labels
reactive Reactive streams and related components
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@akarnokd @danielkec