Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky timeout test #1673

Closed
wants to merge 1 commit into from

Conversation

danielkec
Copy link
Contributor

Seems like it can take more than 1 millis to finish onSubscribe on slower machine

Running TestSuite
Tests run: 2915, Failures: 1, Errors: 0, Skipped: 1401, Time elapsed: 133.362 sec <<< FAILURE! - in TestSuite
optional_spec104_mustSignalOnErrorWhenFails(io.helidon.common.reactive.MultiTimeoutNormalTckTest)  Time elapsed: 0.031 sec  <<< FAILURE!
java.lang.RuntimeException: Publisher threw exception (Async error during test execution: onSubscribe should be called prior to onError always) instead of signalling error via onError!
Caused by: java.lang.AssertionError: Async error during test execution: onSubscribe should be called prior to onError always
Caused by: org.reactivestreams.tck.TestEnvironment$Latch$ExpectedClosedLatchException: onSubscribe should be called prior to onError always
Results :
Failed tests: 
  MultiTimeoutNormalTckTest>PublisherVerification.optional_spec104_mustSignalOnErrorWhenFails:391 » Runtime
Tests run: 2915, Failures: 1, Errors: 0, Skipped: 1401
12:24:29,868 [INFO] parallel='none', perCoreThreadCount=true, threadCount=0, useUnlimitedThreads=false, threadCountSuites=0, threadCountClasses=0, threadCountMethods=0, parallelOptimized=true

Signed-off-by: Daniel Kec daniel.kec@oracle.com

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec self-assigned this Apr 21, 2020
@danielkec danielkec added reactive Reactive streams and related components bug Something isn't working labels Apr 21, 2020
@akarnokd
Copy link
Collaborator

Oh, the issue is with scheduling the timeout before calling the downstream's onSubscribe. I'll post a fix shortly.

@akarnokd
Copy link
Collaborator

See #1674

@danielkec danielkec closed this Apr 22, 2020
@danielkec
Copy link
Contributor Author

Closed in favor of #1674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reactive Reactive streams and related components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants