New media support API. #1356
Merged
New media support API. #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a couple more changes that are needed for the multipart support and that needs to be removed from this PR. |
romain-grecourt
force-pushed
the
media-support
branch
from
07b1913
to
80609ed
Compare
- make constructor of HashParameters protected, add factory methods - minimize changes (i.e remove changes that are not critical and directly related to this PR) - change the static get() methods to create()
romain-grecourt
force-pushed
the
media-support
branch
from
80609ed
to
64da0a2
Compare
Verdent
requested changes
Feb 10, 2020
media/jsonp/common/src/test/java/io/helidon/media/jsonp/common/JsonpReaderTest.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/HashResponseHeaders.java
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/NettyWebServer.java
Show resolved
Hide resolved
tomas-langer
requested changes
Feb 10, 2020
common/http/src/main/java/io/helidon/common/http/CharMatcher.java
Outdated
Show resolved
Hide resolved
common/http/src/main/java/io/helidon/common/http/CharMatcher.java
Outdated
Show resolved
Hide resolved
media/jsonp/common/src/test/java/io/helidon/media/jsonp/common/JsonpReaderTest.java
Outdated
Show resolved
Hide resolved
media/jsonp/common/src/test/java/io/helidon/media/jsonp/common/JsonpReaderTest.java
Outdated
Show resolved
Hide resolved
romain-grecourt
force-pushed
the
media-support
branch
from
1496770
to
627ed2e
Compare
tomas-langer
approved these changes
Feb 11, 2020
Verdent
approved these changes
Feb 11, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked media support API, to be used by the upcoming HTTP client and multipart support.