Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Body API One Pager #885

Conversation

romain-grecourt
Copy link
Contributor

@romain-grecourt romain-grecourt commented Aug 8, 2019

Message body API proposal.

Copy link
Contributor Author

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add review comments from the meeting with @tomas-langer .


// consume a server request payload
MessageBodyReadableContent content = serverRequest.content();
Mono<Foo> mono = content.readerContext().unmarshall(content, fooType);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be fluent.

docs-internal/message-body-api.md Show resolved Hide resolved
docs-internal/message-body-api.md Show resolved Hide resolved
// sets the Content-Type header value if not already set
}

public void contentLength(long contentLength) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is not relevant in the case of a client request, add a note to state that the client writer context would use be a special implementation that would do a no-op.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do concur Sir.

docs-internal/message-body-api.md Show resolved Hide resolved
docs-internal/message-body-api.md Outdated Show resolved Hide resolved
docs-internal/message-body-api.md Outdated Show resolved Hide resolved
docs-internal/message-body-api.md Outdated Show resolved Hide resolved
docs-internal/message-body-api.md Show resolved Hide resolved
docs-internal/message-body-api.md Show resolved Hide resolved
@romain-grecourt romain-grecourt changed the title Add message body API proposal Message Body API One Pager Sep 10, 2019
@romain-grecourt
Copy link
Contributor Author

new API has been merged #1356

@romain-grecourt romain-grecourt deleted the message-body-api-proposal branch February 11, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants