-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message Body API One Pager #885
Message Body API One Pager #885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add review comments from the meeting with @tomas-langer .
|
||
// consume a server request payload | ||
MessageBodyReadableContent content = serverRequest.content(); | ||
Mono<Foo> mono = content.readerContext().unmarshall(content, fooType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be fluent.
// sets the Content-Type header value if not already set | ||
} | ||
|
||
public void contentLength(long contentLength) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is not relevant in the case of a client request, add a note to state that the client writer context would use be a special implementation that would do a no-op.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do concur Sir.
new API has been merged #1356 |
Message body API proposal.