Improve Metadata update error handling #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make Plugins.PluginFailed a checked exception to force error handling - Wrap Plugins.PluginFailed with Metadata.UpdatedFailed as another checked exception to expose metadata update errors - Metadata.UpdateFailed is explicitly thrown by every public methods of Metadata that performs an update check Promote io.helidon.build.cli.codegen.Unchecked to io.helidon.build.util.Unchecke Rename util module from helidon.build.utils to io.helidon.build.util (same as the package name) Fixes helidon-io#487
barchetta
approved these changes
Sep 29, 2021
Closed
romain-grecourt
added a commit
to romain-grecourt/helidon-build-tools
that referenced
this pull request
Jan 4, 2022
Make Plugins.PluginFailed a checked exception to force error handling Wrap Plugins.PluginFailed with Metadata.UpdatedFailed as another checked exception to expose metadata update errors Metadata.UpdateFailed is explicitly thrown by every public methods of Metadata that performs an update check Promote io.helidon.build.cli.codegen.Unchecked to io.helidon.build.util.Unchecke Fixed a bug in Plugin log when Plugin.execute is invoked with a null consumer for output. Fixes helidon-io#487 Fixes helidon-io#507 (forward port of helidon-io#506)
romain-grecourt
added a commit
that referenced
this pull request
Jan 5, 2022
* Improve Metadata update error handling: Make Plugins.PluginFailed a checked exception to force error handling Wrap Plugins.PluginFailed with Metadata.UpdatedFailed as another checked exception to expose metadata update errors Metadata.UpdateFailed is explicitly thrown by every public methods of Metadata that performs an update check Promote io.helidon.build.cli.codegen.Unchecked to io.helidon.build.util.Unchecke Fixed a bug in Plugin log when Plugin.execute is invoked with a null consumer for output. Fixes #487 Fixes #507 (forward port of #506) * Always pass-in a string consumer for Plugins.execute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Metadata update error handling:
Promote io.helidon.build.cli.codegen.Unchecked to io.helidon.build.util.Unchecke
Rename util module from helidon.build.utils to io.helidon.build.util (same as the package name)
Fixes #487