Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port #506 to 3.x #507

Closed
romain-grecourt opened this issue Sep 29, 2021 · 0 comments · Fixed by #600
Closed

port #506 to 3.x #507

romain-grecourt opened this issue Sep 29, 2021 · 0 comments · Fixed by #600
Assignees
@romain-grecourt
Labels
backport
Milestone
3.0.0-M2

Comments

@romain-grecourt
Copy link
Contributor

romain-grecourt commented Sep 29, 2021 •
edited
Loading

Port #506 to 3.x
@romain-grecourt romain-grecourt added this to the 3.0.0 milestone Sep 29, 2021
@romain-grecourt romain-grecourt self-assigned this Jan 4, 2022
romain-grecourt added a commit to romain-grecourt/helidon-build-tools that referenced this issue Jan 4, 2022
@romain-grecourt
Improve Metadata update error handling:
a657e0c 
Make Plugins.PluginFailed a checked exception to force error handling
Wrap Plugins.PluginFailed with Metadata.UpdatedFailed as another checked exception to expose metadata update errors
Metadata.UpdateFailed is explicitly thrown by every public methods of Metadata that performs an update check
Promote io.helidon.build.cli.codegen.Unchecked to io.helidon.build.util.Unchecke

Fixed a bug in Plugin log when Plugin.execute is invoked with a null consumer for output.

Fixes helidon-io#487
Fixes helidon-io#507 (forward port of helidon-io#506)
@romain-grecourt romain-grecourt mentioned this issue Jan 4, 2022
Merged
romain-grecourt added a commit that referenced this issue Jan 5, 2022
@romain-grecourt
Improve Metadata update error handling: (#600)
986d63a 
* Improve Metadata update error handling:

Make Plugins.PluginFailed a checked exception to force error handling
Wrap Plugins.PluginFailed with Metadata.UpdatedFailed as another checked exception to expose metadata update errors
Metadata.UpdateFailed is explicitly thrown by every public methods of Metadata that performs an update check
Promote io.helidon.build.cli.codegen.Unchecked to io.helidon.build.util.Unchecke

Fixed a bug in Plugin log when Plugin.execute is invoked with a null consumer for output.

Fixes #487
Fixes #507 (forward port of #506)

* Always pass-in a string consumer for Plugins.execute
@romain-grecourt romain-grecourt modified the milestones: 3.0.0, 3.0.0-M2 Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romain-grecourt romain-grecourt

Labels
backport
Projects
None yet
Milestone
3.0.0-M2
Development

Successfully merging a pull request may close this issue.

Improve Metadata update error handling: romain-grecourt/helidon-build-tools
1 participant
@romain-grecourt