Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch-globals.js: fix test function name #846

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

ecki
Copy link
Contributor

@ecki ecki commented Sep 19, 2024

Fix an accidental copy/paste error to make test name unique.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 19, 2024
@woess woess self-assigned this Sep 20, 2024
@ecki
Copy link
Contributor Author

ecki commented Sep 21, 2024

Feel free to squash it. Should I provide a test with other primitive types? (Maybe add an assert helper which takes a list of candidates?

assertThrowsArg([true,42,123n,““,Symbol("Id")], (arg) => new Header(arg), TypeError);

like that?

@iamstolis
Copy link
Member

Feel free to squash it.

It would better to squash it on your side: this way the change(set) remains authored by you and the merged changes are properly linked with this PR.

Should I provide a test with other primitive types?

Feel free to leave it as it is. Considering how our specializations are written, there is just a little chance that other primitive types will behave differently. Of course, if you wish to add these tests, feel free to do so.

@iamstolis
Copy link
Member

It would better to squash it on your side: ...

So, do you plan to squash it yourself?

@ecki ecki force-pushed the patch-1 branch 2 times, most recently from 51aadd0 to 86c2f92 Compare September 30, 2024 15:02
@ecki
Copy link
Contributor Author

ecki commented Sep 30, 2024

Thanks for the reminder i squashed and rebased it.

Fix an accidental copy/paste error to make test name unique.
graalvmbot pushed a commit that referenced this pull request Oct 2, 2024
@graalvmbot graalvmbot merged commit 1532e30 into oracle:master Oct 2, 2024
1 check passed
@ecki ecki deleted the patch-1 branch October 2, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants