Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMD64DarwinUContextRegisterDumperFeature is not triggered for org.graalvm.nativeimage.Platform.IOS_AMD64 #4162

Closed
kirillp opened this issue Dec 28, 2021 · 11 comments
Assignees

Comments

@kirillp
Copy link

kirillp commented Dec 28, 2021

After fixing this #3859
I've found a new issue: AMD64DarwinUContextRegisterDumperFeature is not triggered for
org.graalvm.nativeimage.Platform.IOS_AMD64
GraaVM 22.0 is affected

As a result we can see a following error in during build

Fatal error: com.oracle.svm.core.util.VMError$HostedError: guarantee failed
at com.oracle.svm.core.util.VMError.shouldNotReachHere(VMError.java:68)
at com.oracle.svm.core.util.VMError.guarantee(VMError.java:82)
at com.oracle.svm.core.SubstrateSegfaultHandlerFeature.beforeAnalysis(SubstrateSegfaultHandler.java:76)
at com.oracle.svm.hosted.NativeImageGenerator.lambda$runPointsToAnalysis$9(NativeImageGenerator.java:694)

kirillp pushed a commit to Montura/graal that referenced this issue Dec 28, 2021
… triggered for org.graalvm.nativeimage.Platform.IOS_AMD64
@kirillp
Copy link
Author

kirillp commented Dec 28, 2021

I fixed this by adding required annotations
Montura@d9d9a1a

after the fix the build works again

@jperedadnr
Copy link

I've run into this same issue, and the proposed fix works for me too.

@teshull teshull self-assigned this Jan 3, 2022
@teshull
Copy link
Member

teshull commented Jan 3, 2022

From my perspective, the issue here is that IOS is a subclass of DARWIN, but IOS_AARCH64 and IOS_AMD64 are not subclasses of DARWIN_AARCH64 and DARWIN_AMD64. I think also there should be an explicit MACOS leaf platform.

You can track the fix at #4171

@kirillp
Copy link
Author

kirillp commented Jan 3, 2022

can we see this in 22 ?

@jperedadnr
Copy link

Tested #4171, works fine on macOS (AMD64), iOS (AArch64) and iOS simulator (AMD64).

@teshull
Copy link
Member

teshull commented Mar 2, 2022

#4171 has been merged, so this should be resolved

@teshull teshull closed this as completed Mar 2, 2022
@Noisyfox
Copy link
Contributor

Noisyfox commented Mar 18, 2022

So will this be released in 22.1 or 22.0.x?

@kirillp
Copy link
Author

kirillp commented Mar 18, 2022

22.1 I guess, you can find my build in my repo already. We have migrated to 22.1 beta with 17. And then I was removed

@Noisyfox
Copy link
Contributor

Yeah I'm trying to apply your patch to 22.0.

@teshull
Copy link
Member

teshull commented Mar 18, 2022

Yes, this will be part of 22.1

@kirillp
Copy link
Author

kirillp commented Mar 18, 2022

My patch is for java 17. We decided to drop j11 since it is maintenance state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants