Do not log the password #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Jones <christopher.jones@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
gotsysdba
approved these changes
Sep 18, 2025
ViliTajnic
pushed a commit
that referenced
this pull request
Sep 26, 2025
Signed-off-by: Christopher Jones <christopher.jones@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed logging of the password which is a security risk
Whitespace incidentally got fixed; I strongly recommend using a precommit hook like:
a sample config file is https://github.com/oracle/python-oracledb/blob/main/.pre-commit-config.yaml