Custom model telemetry #1239
Open
Custom model telemetry #1239
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le/accelerated-data-science into use_custom_model_name_in_deployment
agrimk
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
|
@agrimk could you add a description to this PR? If PR is not ready for review, please mark it as WIP. |
| @@ -785,8 +794,8 @@ def _create_deployment( | |||
| # we arbitrarily choose last 8 characters of OCID to identify MD in telemetry | |||
| telemetry_kwargs = {"ocid": get_ocid_substring(deployment_id, key_len=8)} | |||
|
|
|||
| if Tags.BASE_MODEL_CUSTOM in tags: | |||
| telemetry_kwargs["custom_base_model"] = True | |||
| if is_custom_base_model: | |||
There was a problem hiding this comment.
can you add some details in the description why this approach is needs vs. what we already had?
| @@ -214,6 +214,7 @@ def create( | |||
| ) | |||
| aqua_model = model_app.create( | |||
| model_id=create_deployment_details.model_id, | |||
| display_name=create_deployment_details.model_name, | |||
There was a problem hiding this comment.
I think we did not add model name intentionally to avoid leaking user input model names, instead relied on the config information to get the model family. Can you clarify what is sent via UI here?
| @@ -647,6 +651,7 @@ def _create_multi( | |||
| } | |||
|
|
|||
| model_name = f"{MODEL_NAME_DELIMITER} ".join(model_name_list) | |||
| is_custom_base_model = Tags.BASE_MODEL_CUSTOM in aqua_model.freeform_tags | |||
There was a problem hiding this comment.
instead of creating is_custom_base_model, copy the tag in the _create function itself:
for tag in [
Tags.AQUA_SERVICE_MODEL_TAG,
Tags.AQUA_FINE_TUNED_MODEL_TAG,
Tags.AQUA_TAG,
Tags.BASE_MODEL_CUSTOM
]:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.