Skip to content

JCS-14023 Status check missing from public subnet provisioning #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024
Merged

JCS-14023 Status check missing from public subnet provisioning #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions terraform/modules/provisioners/provisioning.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Licensed under the Universal Permissive License v1.0 as shown at https://oss.oracle.com/licenses/upl.

resource "null_resource" "status_check" {
count = var.is_bastion_instance_required || var.is_rms_private_endpoint_required ? var.num_vm_instances : 0
count = var.assign_public_ip || var.is_bastion_instance_required || var.is_rms_private_endpoint_required ? var.num_vm_instances : 0
depends_on = [null_resource.dev_mode_provisioning]

// Connection setup for all WLS instances
Expand Down Expand Up @@ -121,7 +121,7 @@ resource "null_resource" "status_check" {
}

resource "null_resource" "print_service_info" {
count = var.is_bastion_instance_required || var.is_rms_private_endpoint_required ? var.num_vm_instances : 0
count = var.assign_public_ip || var.is_bastion_instance_required || var.is_rms_private_endpoint_required ? var.num_vm_instances : 0
depends_on = [null_resource.status_check]

// Connection setup for all WLS instances
Expand All @@ -146,7 +146,7 @@ resource "null_resource" "print_service_info" {
}

resource "null_resource" "cleanup" {
count = var.is_bastion_instance_required || var.is_rms_private_endpoint_required ? var.num_vm_instances : 0
count = var.assign_public_ip || var.is_bastion_instance_required || var.is_rms_private_endpoint_required ? var.num_vm_instances : 0
depends_on = [null_resource.print_service_info]


Expand Down
4 changes: 1 addition & 3 deletions terraform/modules/provisioners/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,9 @@ variable "bastion_host_private_key" {
default = ""
}

#TODO: Check if this variable is really needed.
variable "assign_public_ip" {
type = bool
description = "Set to true if you want the compute instance to have a public IP in addition to the private ip. Use with caution"
default = true
description = "Set to true if the WebLogic compute instances will be created in a public subnet and should have a public IP"
}

variable "is_bastion_instance_required" {
Expand Down