Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Use the default osx image. #76

Merged
merged 3 commits into from
May 29, 2019
Merged

travis: Use the default osx image. #76

merged 3 commits into from
May 29, 2019

Conversation

rillian
Copy link
Contributor

@rillian rillian commented May 28, 2019

XCode 7.3 (based on macOS 10.11) is out of support, and cannot
complete tests because the brew upgrade step has so many
packages to build. Use the default image instead, which is
currently macOS 10.13 and Xcode 9.4.1.

This seems to resolve the recent travis test failures on macOS.

XCode 7.3 (based on macOS 10.11) is out of support, and cannot
complete tests because the `brew upgrade` step has so many
packages to build. Use the default image instead, which is
currently macOS 10.13 and Xcode 9.4.1.

This seems to resolve the recent travis test failures on macOS.
@rillian
Copy link
Contributor Author

rillian commented May 28, 2019

Note that the linux 2.7 python job has started failing in the meantime, so tests still won't be green with this commit. I suspect that can be fixed by removing coverage from that job as was done for the jython job, if that's a reasonable approach?

Assume we have a more recent version (3 or later) of pytest
which can be invoked as such. Also remove the report generation
switches. The codecov.io docs don't suggest this, so I don't
think it's necessary for upload to the site. There's no point
generating the reports in ci if they're not uploaded anywhere.
The default pytest included in the travis 2.7 package (3.3.0) is
too old for the pytest_cov package we install. Use pip to upgrade
it before running tests.

Resolves the build failure with python 2.7 on linux.
@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #76 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #76     +/-   ##
=========================================
- Coverage   87.24%   87.14%   -0.1%     
=========================================
  Files          26       27      +1     
  Lines         980      988      +8     
=========================================
+ Hits          855      861      +6     
- Misses        125      127      +2
Impacted Files Coverage Δ
pyoracc/__init__.py 75% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18c9e7...bb30753. Read the comment docs.

@rillian rillian force-pushed the tests branch 3 times, most recently from 9982fb3 to bb30753 Compare May 28, 2019 16:32
@rillian
Copy link
Contributor Author

rillian commented May 28, 2019

Adding Python 3.7 on Linux turned out to be a bridge too far, but the additional commit have all tests passing again. @jayanthjaiswal, @raquel-ucl what do you think?

@jayanthkmr
Copy link
Contributor

jayanthkmr commented May 29, 2019

@rillian Great work! Thanks. Removing coverage won't hurt much.

@raquelalegre raquelalegre self-requested a review May 29, 2019 15:27
@raquelalegre
Copy link
Contributor

Thanks @rillian!

@rillian
Copy link
Contributor Author

rillian commented May 29, 2019

Thanks for reviewing! I don't have commit access. Could someone please push the merge button so we can make the badge green? :)

@giordano giordano merged commit 4ea197a into oracc:master May 29, 2019
@giordano
Copy link
Contributor

There you go!

@rillian
Copy link
Contributor Author

rillian commented May 29, 2019

danke!

@rillian rillian deleted the tests branch May 29, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants