Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4062: App.razor - moves loading body resources above blazor.web.js #4064

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

thabaum
Copy link
Contributor

@thabaum thabaum commented Mar 25, 2024

Pull Request

Fixes #4062

Description

Moves resources loading in the body of App.razor file above loading the blazor.web.js

Screenshots

image
image

@thabaum
Copy link
Contributor Author

thabaum commented Mar 25, 2024

@sbwalker I am not sure I just wanted to share this result, but I am not 100% it does not affect something I am not thinking of in Oqtane. I appreciate your time reviewing.

@sbwalker
Copy link
Member

@thabaum basically you moved all statically defined JS references to the end of the body section - correct?

@thabaum
Copy link
Contributor Author

thabaum commented Mar 25, 2024

@sbwalker yes, and this improved logging out interactive/auto mode blink of an eye...

@sbwalker
Copy link
Member

@thabaum I believe logout performance was improved by #4043 and is not related to this change

@thabaum
Copy link
Contributor Author

thabaum commented Mar 25, 2024

@sbwalker I pretty much main thing is put the blazor.web.js at the end as this pulls off all the magic tricks.

@sbwalker sbwalker merged commit fb4171a into oqtane:dev Mar 25, 2024
1 check passed
@thabaum
Copy link
Contributor Author

thabaum commented Mar 25, 2024

@sbwalker after further review, not sure how I ended up wtih those results shown, but this PR does not do it. And when I had those results it worked great in interactive auto mode. Anyhow this can be reverted back unless it does not seem to cause any issues.. my apologies. Somehow I had it show me this source, and also the interactive/auto ran fast logging out, now I cannot reproduce this behavior or make the code get displayed as shown. Strange... you can see in #4062 screenshot it is the same editor.

I am not sure what to think here as I am pretty sure I generated those results above somehow while in Interactive/Auto. While I could produce those results seems like it would log out rapidly.

Maybe I am just experiencing some glitches in VS? Or is there something finding scripts in the page body and re-writing them in oqtane?

I am updating visual studio now, it may have bugged me up as I didn't notice it was available.

@sbwalker
Copy link
Member

@thabaum I don't think it has an impact on the actual framework at run-time, but I do like the idea of the Blazor JS reference being at the very bottom of the body so I will not revert this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants