Updates theme bootstrap and bootswatch to version 5.3.2 - closes #3772 #3778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thabaum
changed the title
thabaum
changed the title
|
@thabaum most prior upgrades to Bootstrap contained some breaking changes from a UI styling perspective.... have you thoroughly tested Bootstrap 5.3.2 to determine if there are any issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates bootstrap and bootswatch to latest versions without breaking any UI styles or controls like previous attempt.
Closes #3772
As far as styling goes, it seems to present things as intended.
Functionality is limited on some UI components with static SSR enabled, but no styling issues with Theme Creator or Oqtane themes.
I did find an issue possibly with the ThemeCreator project with ModuleInstance I commented out to get past quickly.
I will test this more to see if it is a bug or something just in my environment at the time.
I will test functionality against the current dev repository to see if any issues need reopened. I sometimes forget to set the new installs to static SSR and may think something is fixed as I need to be sure to double check this setting while reporting.
I found no issues with this PR running global interactive mode hosting model.
If you can verify having same issues I see with Control Panel functionality not working in static SSR then this is good to go. I changed to both versions of bootstrap and seen similar results myself.