Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #288

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

alexparish
Copy link
Contributor

@alexparish alexparish commented Nov 6, 2024

Summary

  • Removed prop-types and @types/prop-types dependencies - as well as reference in README.md - as these packages are no longed used.
  • Removed unused tslib dependency and corresponding redundant TypeScript config option.

Issues

@junaed-optimizely
Copy link
Contributor

Hey @alexparish, thanks for the cleanup. You have to sign the CLA to be eligible to contribute! Please let me know if you have done that already!

@alexparish
Copy link
Contributor Author

@junaed-optimizely Done! Thanks for the heads up.

@junaed-optimizely
Copy link
Contributor

junaed-optimizely commented Nov 8, 2024

@alexparish , could you please close this PR, merge latest master and open another PR again ?

Prisma code analysis is supposed to work, and is required before merging. Before reporting I want to try again.

You can copy the description from this PR...

Sorry for the inconvenience.

EDIT: Ignore this comment for the time being. I have found a doc to resolve some of the checks. I will get back to you if you have to do anything else from your side.

@junaed-optimizely junaed-optimizely merged commit 068382a into optimizely:master Nov 12, 2024
19 of 21 checks passed
@alexparish alexparish deleted the remove-unused-deps branch November 12, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Remove unused dependencies
2 participants