Align to use virtual threads #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In scope of this ticket I removed synchronized blocks as they pin virtual thread to carrier thread. * Expose user way to inject ThreadFactory for creating virtual threads
|
@wyhasany Thanks for your contribution! If not done yet, can you sign our CLA? https://github.com/optimizely/java-sdk/blob/master/CONTRIBUTING.md |
|
@jaeopt just done it |
jaeopt
requested changes
Apr 1, 2024
core-httpclient-impl/src/main/java/com/optimizely/ab/NamedThreadFactory.java
Outdated
Show resolved
Hide resolved
core-httpclient-impl/src/main/java/com/optimizely/ab/NamedThreadFactory.java
Outdated
Show resolved
Hide resolved
core-httpclient-impl/src/main/java/com/optimizely/ab/event/AsyncEventHandler.java
Outdated
Show resolved
Hide resolved
…adFactory.java Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
|
@jaeopt Thank you for review. I applied all yours suggestions |
|
@wyhasany Thanks for your contribution. It's merged and will be included in the next release (next week). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues